Skip to content

Add init test for cacheResult flag #17150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

q-ata
Copy link
Contributor

@q-ata q-ata commented Mar 26, 2023

This test checks for the presence of the cacheResult = true flag on the call to cachedEval from Semantic.scala:992. Without that flag, the compiler crashes on this test with -Ysafe-init.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @q-ata 🎉

@olhotak olhotak merged commit 363802f into scala:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants